Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align prefix for stepped lists #4735

Merged
merged 8 commits into from Apr 26, 2023

Conversation

ClementChaumel
Copy link
Contributor

@ClementChaumel ClementChaumel commented Apr 17, 2023

Done

Align stepped lists prefixes

/docs/examples/patterns/lists/lists-stepped-detailed

Screenshots

image

@webteam-app
Copy link

webteam-app commented Apr 17, 2023

@bartaz
Copy link
Contributor

bartaz commented Apr 20, 2023

As discussed with Lyubo:

  • font size of number same as heading, on same baseline, same font style
  • circle size of line height (or .5rem bigger)
  • spacing between circle and heading fixed (1.5rem?)

@lyubomir-popov
Copy link
Contributor

@bartaz mockups here, to confirm circles == line-height + .5rem

@ClementChaumel

This comment was marked as outdated.

@bartaz bartaz force-pushed the typography-changes-fix-stepped-lists branch from 0f2c1a8 to 2dcf17d Compare April 20, 2023 15:33
@bartaz bartaz force-pushed the typography-changes-fix-stepped-lists branch from 594dd61 to 1d5ec7c Compare April 21, 2023 06:08
@lyubomir-popov
Copy link
Contributor

I wonder whether we even need the circle. Thjis looks good to me (increased margin-right to 1.5rem):

image

@bartaz
Copy link
Contributor

bartaz commented Apr 21, 2023

I wonder whether we even need the circle. Thjis looks good to me (increased margin-right to 1.5rem):

@lyubomir-popov No separator at all? Dot at least for consistency with default ordered list styling?

  1. something
  2. something

@bartaz
Copy link
Contributor

bartaz commented Apr 21, 2023

@lyubomir-popov And don't forget about default "stacked" version, also on small screens, where content is below, and needs to be aligned. Circle gives us consistent alignment, numbers will differ when every step has a number in different width:

image

Copy link
Contributor Author

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't approve since it's originally my PR but I think it's in a good state!

scss/_patterns_lists.scss Outdated Show resolved Hide resolved
@lyubomir-popov
Copy link
Contributor

@bartaz just one thing, can we please make the stepped list example use h2s? This way people who copy-paste from here will get a better, non-bold default. I mostly use h2s for these so chances are it will be the right choice.

@lyubomir-popov
Copy link
Contributor

+1 for an easy merge after the above hasbeen adressed

@bartaz bartaz merged commit 76d0d3e into typography-changes Apr 26, 2023
6 checks passed
@bartaz bartaz deleted the typography-changes-fix-stepped-lists branch April 26, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants