Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated Suru strips from the website #4752

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

ClementChaumel
Copy link
Contributor

@ClementChaumel ClementChaumel commented Apr 28, 2023

Done

Removed the suru strips from the index page and other templates

I kept the current accent colour.

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4752.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Apr 28, 2023

I think we can drop the custom colours (including orange), as it was only needed for suru.

https://github.com/canonical/vanilla-framework/blob/9a4fb40c64aa58b6adc19b296971815bd95781c9/scss/docs/site.scss#LL5C1-L14C57

Let's use Vanilla grey defaults instead.

@bartaz bartaz merged commit bd04ea6 into canonical:main Apr 28, 2023
5 checks passed
@bartaz bartaz changed the title Remove Suru strips Remove outdated Suru strips from the website Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants