Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce form input width - 10em to 8em #4798

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

Jim-Dillon
Copy link
Contributor

@Jim-Dillon Jim-Dillon commented Jun 19, 2023

Done

Reduced the input width to remedy the issue with the form input field on a smaller screen window.

Fixes #4761

QA

What for:

  • Visit https://ubuntu.com/blog.
  • Before fix, when window has width just over 620px the input field border line is cut off
  • After fix, the line stays centred

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

webteam-app commented Jun 19, 2023

Demo started here: https://vanilla-framework-4798.demos.haus/

@bartaz
Copy link
Contributor

bartaz commented Jun 20, 2023

Thanks @Jim-Dillon for this fix.

Because it's the first bugfix that would go into next release, could you also increase the version number in package.json to 3.15.1?

"version": "3.15.0",

@Jim-Dillon
Copy link
Contributor Author

No problem @bartaz, just made that change.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bartaz bartaz merged commit 4a66fcc into canonical:main Jun 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce min-width of email input to 8rem
3 participants