Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is-dark class name for consistency #4819

Merged
merged 2 commits into from Jul 4, 2023
Merged

Use is-dark class name for consistency #4819

merged 2 commits into from Jul 4, 2023

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jul 3, 2023 •
edited

Done

Revert from using on-dark class to switch theme, to keep new components consistent with existing themes.

QA

@bartaz bartaz marked this pull request as ready for review July 3, 2023 15:15
ClementChaumel
ClementChaumel approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👍️

@bartaz bartaz merged commit 2f3c109 into canonical:vanilla-4.0 Jul 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementChaumel ClementChaumel ClementChaumel approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartaz @ClementChaumel