Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update section component #4823

Merged
merged 1 commit into from Jul 5, 2023
Merged

Update section component #4823

merged 1 commit into from Jul 5, 2023

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jul 5, 2023 •
edited

Done

Updated section component with shallow and deep version, deprecate block.

QA

  • Open demo
  • Review updated section examples and docs

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4823.demos.haus

@bartaz bartaz marked this pull request as ready for review July 5, 2023 13:11
ClementChaumel
ClementChaumel approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there any plan to revisit the way typography spacing is done so we can also have utilities?

@bartaz bartaz merged commit c349a41 into canonical:vanilla-4.0 Jul 5, 2023
5 checks passed
@bartaz bartaz mentioned this pull request Jul 5, 2023
Closed
3 tasks
@bartaz bartaz mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementChaumel ClementChaumel ClementChaumel approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 Review: Code +1 Review: Design +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartaz @webteam-app @ClementChaumel @lyubomir-popov