Update breadcrumb's bottom margin #4842
Conversation
|
Comparing to canonical.com/careers (which I think Lyubo wants to match) we still have too much of the margin I think: 
|
scss/_patterns_breadcrumbs.scss
Outdated
| } | ||
|
|
||
| .p-breadcrumbs__item { | ||
| @extend %default-text; | ||
| @extend %small-caps-text; | ||
|
|
||
| display: inline-block; | ||
| margin-bottom: $spv-nudge-compensation; |
There was a problem hiding this comment.
I think this should be removed, this is some old margin, and we want the margin from small caps text.
scss/_patterns_breadcrumbs.scss
Outdated
| padding-left: 0; | ||
| } | ||
| .p-breadcrumbs__items { | ||
| margin-bottom: $spv--large; |
There was a problem hiding this comment.
I'm not sure if this is needed. If we have margin from small caps text on the __item this probably should not be needed.
There was a problem hiding this comment.
The margin from small caps is overriden by margin-bottom: $spv-nudge-compensation; which I'm reluctant to touch because it sounds like some baseline grid magic
There was a problem hiding this comment.
Ah sorry I was confused what your previous comment referred to!
There was a problem hiding this comment.
Sure, I guess it used to be a margin to align with baseline, but because we are replacing margin completely, changing font text style to something else etc, old styles need to be removed, so we can start with clean state, and then see if they baseline needs adjustments.
But if we use defaults from small caps we should not need anything else (as that should be aligned already).
| margin-left: 0; | ||
| padding-left: 0; | ||
| } | ||
| .p-breadcrumbs__items { |
There was a problem hiding this comment.
Thanks for expanding the classname!
Done
Reduce margin-bottom on breadcrumbs to 1rem
Make the breadcrumbs use small caps
Fixes #4818
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention: