Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of hero sections #4843

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jul 24, 2023

Done

Add examples of new brochure site hero sections

Fixes WD-5139

TODO

  • surus are needed to complete hero exampels
  • responsive 25-75 row needed
  • bordered rows and columns needed (descoped for now due to spacing issues)

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4843.demos.haus

@bartaz bartaz changed the title WIP: Add examples of hero sections Add examples of hero sections Jul 27, 2023
@bartaz bartaz marked this pull request as ready for review July 27, 2023 14:42
@juanruitina
Copy link

One comment. The H2 in every hero should be a p element styled as an H2 instead, it is not a heading semantically but rather a subtitle. If we wanna go the extra mile, it seems the best way to convey a subtitle right now is having it as a paragraph next to a heading and wrap it all in an hgroup tag, but don't know how feasible that is given the layouts. There's some extra info on the HTML living standard, and in this article (sorry, went down the rabbit hole).

And a request: in the documentation itself, can you add an id for every specific example so I can link directly to them? That would be useful when handing off designs on Figma, where we can now add a documentation link not only per component, but also per component variant.

So great to see these patterns documented, nice work.

Copy link
Contributor

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👍️

@bartaz bartaz merged commit 0638007 into canonical:main Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants