Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo section updates #4852

Merged
merged 11 commits into from
Aug 11, 2023
Merged

Logo section updates #4852

merged 11 commits into from
Aug 11, 2023

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jul 31, 2023 •
edited

Done

Upstreams new variable width version of logo section from canonical.com

Fixes WD-5199

QA

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4852.demos.haus

@lyubomir-popov
Copy link
Contributor

Nice work, a few things I noticed:

  • Can we use the actual examples from the canonical partner pages, e.g. this one (see the partners dropdown for other partner pages)? This way it will be visible that the logos are now with varying width

  • I'd use 1.5rem gap in the dense version between items

  • I think the negative margins need to go to the parent container, as otherwise the

@lyubomir-popov
Copy link
Contributor

Looks good. I would only modify this example to make it more plausible - you would only have a br if you want to prevent an orphan, and the line looks better with at least the first line filled all the way. So maybe full first line, 3 logos on the second?
image](https://github.com/canonical/vanilla-framework/assets/2741678/38448be5-4bc5-47f7-8fae-f19b73fad6f7)

@bartaz bartaz changed the title WIP: Add variable width logo section Logo section updates Aug 10, 2023
@bartaz bartaz marked this pull request as ready for review August 10, 2023 15:01
albertkol
albertkol approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@albertkol albertkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@albertkol
Copy link
Contributor

Dark logos pretty.

@bartaz bartaz merged commit 75ace91 into canonical:main Aug 11, 2023
5 checks passed
@bartaz bartaz deleted the logo-section-variable branch August 11, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertkol albertkol albertkol approved these changes

Assignees
No one assigned
Labels
Feature 🎁 New feature or request Review: Code +1 Review: Design +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartaz @webteam-app @lyubomir-popov @albertkol