Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust font-weight of small caps and h5 #4873

Merged
merged 4 commits into from Sep 12, 2023
Merged

Conversation

lyubomir-popov
Copy link
Contributor

@lyubomir-popov lyubomir-popov commented Sep 5, 2023

Done

  • adjust font weight of small caps and h5 to 550

QA

  • Open demo
  • Verify new weight

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4873.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Sep 5, 2023

@lyubomir-popov Could you change version in package.json file to 4.2.1 ?

"version": "4.2.0",

@lyubomir-popov
Copy link
Contributor Author

done

@bartaz bartaz changed the title adjust font-weight of small caps and h5 Adjust font-weight of small caps and h5 Sep 12, 2023
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit 38ffd69 into canonical:main Sep 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants