Add paper background support to side navigation #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4881.demos.haus |
bartaz
commented
Oct 2, 2023
| @@ -539,7 +539,7 @@ | |||
| .p-side-navigation--raw-html { | |||
| @include vf-side-navigation-raw-html-theme-light; | |||
|
|
|||
| &.is-light { | |||
| &.is-dark { | |||
There was a problem hiding this comment.
Drive-by: fixed a broken class name when switching from light theme to dark theme in raw HTML variant.
bartaz
commented
Oct 2, 2023
| @@ -12,7 +12,7 @@ function generateMetrics(file, metricsArray) { | |||
| { | |||
| name: 'Stylesheet size', | |||
| benchmark: 150000, | |||
| threshold: 380000, | |||
| threshold: 430000, | |||
There was a problem hiding this comment.
Adding more themes to side navigation increases the size of CSS noticeably.
It's OK, because in the end this additional CSS is quite repetitive and will GZIP nicely, so doesn't affect performance too much.
But we need to increase our allowed thresholds so that the tests pass.
|
@bartaz Looks like the second one (with icons) has a transparent background on mobile
|
andesol
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
As part one building block of new documentation layout this PR updates side navigation component by adding new paper background colour support to the light theme.
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention: