Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh styles of table of contents component #4885

Merged
merged 3 commits into from Oct 5, 2023

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Oct 4, 2023

Done

As part of working on documentation layout we are refreshing the styling of an old table of contents component:

  • use muted heading for title style
  • use link styles on table of contents items to make them accessible
  • add spacing between items similar to side navigation

QA

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4885.demos.haus

@bartaz bartaz marked this pull request as ready for review October 4, 2023 10:56
@juanruitina
Copy link

juanruitina commented Oct 4, 2023

Sorry for showing up here unannounced, but have some minor feedback. From #4777: may I ask you to make the "On this page" heading an H2 instead of H4? In most cases it should be that heading level.

I'd also remove the colon from the headings, we don't usually use them.

We still need to make a decision on mobile behaviour, but we can handle that separately. So great to see this component improved :)

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

- making all muted headings use same styles
- adjusting headling level for table of contents header
- overriding visited link colour (as these will be anchors)
@bartaz bartaz merged commit 496b769 into canonical:main Oct 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants