Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show suru on all screens #4908

Merged
merged 2 commits into from Nov 22, 2023
Merged

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Nov 20, 2023

Done

  • Suru component was hidden on smaller screens, now it's visible on all screens.

Fixes #4894
Fixes WD-7506

QA

  • Open demo url
  • Go to /docs/examples/patterns/suru/default and try resizing the page.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@bartaz
Copy link
Contributor

bartaz commented Nov 21, 2023

@aaryanporwal Looks good. Just one thing - because it's a bug fix and we haven't bumped version number yet, we need to bump it now.

So in package.json please update Vanilla version to 4.5.1

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartaz bartaz merged commit 8db7367 into canonical:main Nov 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main suru hidden on small screens
2 participants