Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty state documentation #4914

Merged
merged 1 commit into from Nov 24, 2023

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Nov 22, 2023

Done

Fixes WD-6189

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@bartaz
Copy link
Contributor

bartaz commented Nov 22, 2023

@aaryanporwal The PR test is failing (due to formatting issues - likely unnecessary or unneeded empty lines) - could you run dotrun test locally and fix those?

Running Prettier via VS Code on the file should do it.

@bartaz
Copy link
Contributor

bartaz commented Nov 23, 2023

@aaryanporwal There is a conflict (I guess because of my layout PR merged) and prettier check is failing on formatting of .md file.

@bartaz bartaz added Review: Code -1 Documentation 馃摑 Documentation changes or updates labels Nov 23, 2023
@aaryanporwal
Copy link
Member Author

Yup, I'll fix that.

@aaryanporwal aaryanporwal force-pushed the emptystate-copydoc branch 2 times, most recently from 71c1e43 to 39856bd Compare November 23, 2023 09:48
@bartaz bartaz merged commit 6215d47 into canonical:main Nov 24, 2023
5 checks passed
@bartaz bartaz changed the title Update empty state documentation [WD-6189] Update empty state documentation Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 馃摑 Documentation changes or updates Review: Code +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants