Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 25/75 grid split support to top navigation #4960

Merged
merged 7 commits into from Feb 1, 2024

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jan 30, 2024

Done

Adds p-navigation__row--25-75 variant that aligns top navigation items with 25/75 grid split of the content below it.

Fixes https://warthogs.atlassian.net/browse/WD-8284

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4960.demos.haus

@bartaz bartaz added the Feature 馃巵 New feature or request label Jan 30, 2024
@bartaz bartaz changed the title Nav grid split WIP: Add 25/75 grid split support to top navigation Jan 30, 2024
@bartaz bartaz changed the title WIP: Add 25/75 grid split support to top navigation Add 25/75 grid split support to top navigation Feb 1, 2024
@bartaz bartaz marked this pull request as ready for review February 1, 2024 09:27
@lyubomir-popov
Copy link
Contributor

looks good thanks @bartaz

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM馃憤

@bartaz bartaz merged commit c0c356e into canonical:main Feb 1, 2024
5 checks passed
@bartaz bartaz deleted the nav-grid-split branch February 1, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants