New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 25/75 grid split support to top navigation #4960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://vanilla-framework-4960.demos.haus |
bartaz
force-pushed
the
nav-grid-split
branch
from
January 30, 2024 16:31
40d7bcb
to
0d428d4
Compare
bartaz
changed the title
Nav grid split
WIP: Add 25/75 grid split support to top navigation
Jan 30, 2024
bartaz
force-pushed
the
nav-grid-split
branch
from
January 30, 2024 16:48
0d428d4
to
d9db395
Compare
bartaz
changed the title
WIP: Add 25/75 grid split support to top navigation
Add 25/75 grid split support to top navigation
Feb 1, 2024
looks good thanks @bartaz |
chillkang
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM馃憤
chillkang
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Adds
p-navigation__row--25-75
variant that aligns top navigation items with 25/75 grid split of the content below it.Fixes https://warthogs.atlassian.net/browse/WD-8284
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots