Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new theme support for base forms #4974

Merged
merged 4 commits into from Feb 7, 2024
Merged

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Feb 7, 2024

Done

  • Add CSS variables theme support for base forms
  • Fixed a minor typo
  • Note: base forms now use border-high-contrast for the light & paper theme

Fixes WD-7596

QA

  • Open demo
  • Go to /docs/example
  • Make sure the base forms are consistent with their themes

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4974.demos.haus

scss/_base_forms.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@bartaz bartaz merged commit 2581050 into canonical:main Feb 7, 2024
5 checks passed
@britneywwc britneywwc deleted the dark-forms branch February 9, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants