Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons themes #5024

Merged
merged 5 commits into from Mar 8, 2024
Merged

Buttons themes #5024

merged 5 commits into from Mar 8, 2024

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 6, 2024

Done

Updates buttons to use new theming.
Deprecates brand buton.

Fixes WD-7595

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-5024.demos.haus

@bartaz bartaz changed the title WIP: Buttons themes Buttons themes Mar 7, 2024
@bartaz bartaz marked this pull request as ready for review March 7, 2024 16:03
@codeEmpress1
Copy link
Contributor

LGTM!

@bartaz bartaz merged commit 86603f1 into canonical:main Mar 8, 2024
4 of 5 checks passed
@bartaz bartaz deleted the buttons-themes branch March 8, 2024 10:38
@bartaz bartaz added Feature 馃巵 New feature or request and removed Maintenance 馃敤 labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants