Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navigation component to new theming #5043

Merged
merged 2 commits into from Apr 5, 2024
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Apr 2, 2024

Done

Updates top navigation to use new theme.

Fixes WD-7598

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

@bartaz bartaz changed the title WIP: Update navigation component to new theming Update navigation component to new theming Apr 3, 2024
@bartaz bartaz added the Feature 馃巵 New feature or request label Apr 3, 2024
@bartaz bartaz marked this pull request as ready for review April 3, 2024 14:19
@mas-who
Copy link
Contributor

mas-who commented Apr 3, 2024

QA looks good, a quick look over the code it seems good but I'd like to have a more detailed code comb through as I don't have the best knowledge for the surrounding context. Please give me a little bit of time.

Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another big theme refactor! Code looks good :)

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM馃帹

@bartaz bartaz merged commit 25ab64e into canonical:main Apr 5, 2024
5 checks passed
@bartaz bartaz deleted the nav-theme branch April 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants