Fix Percy on CircleCI performance issues #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
bartaz
force-pushed
the
get-examples-list
branch
from
4c7f979
to
66d999b
Compare
bartaz
force-pushed
the
get-examples-list
branch
from
66d999b
to
e1ecbe5
Compare
bartaz
changed the title
3 tasks
mas-who
reviewed
Apr 4, 2024
mas-who
reviewed
Apr 4, 2024
mas-who
approved these changes
Apr 4, 2024
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
On Thursday 04.04 CircleCI builds for Percy started to timeout.
For some reason we don't fully understand yet, the process of crawling example links out of the website started to be very slow and time consuming which in the end led to timeout.
To remedy the issue this PR replaces the process of crawling the website (to get example URLs) to simply getting list of example files from file system and constructing URLs out of the file names (because they are jinja templates and there is 1:1 relation between the file paths and URLs).
We also increase CircleCI resources (as suggested by CircleCI itself) to use environment with more CPU cores and RAM.
QA