Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update article pagination to use new theme variables #5126

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 11, 2024

Done

Updates Article Pagination pattern to use new theme variables.

This affects:

  • Color of the previous/next button text. It now uses the default text color.
  • Color of the previous/next button chevrons. It now uses the default icon color.

Fixes WD-11864

While working on this, I also noticed that the back/next buttons can be updated to use the new chevron left/right code, and made #5125.

QA

  • Open demo.
  • Verify that the color of all text & chevrons is correct in all themes.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before:
Screenshot 2024-06-11 at 5 43 37鈥疨M
After:
Screenshot 2024-06-11 at 5 42 47鈥疨M

@webteam-app
Copy link

@jmuzina
Copy link
Member Author

jmuzina commented Jun 11, 2024

Percy build shows minor difference to the left & right chevrons as expected. It doesn't currently capture light/dark/paper screenshots however.

@jmuzina jmuzina added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jun 11, 2024
@jmuzina jmuzina marked this pull request as ready for review June 11, 2024 21:54
@jmuzina
Copy link
Member Author

jmuzina commented Jun 11, 2024

@lyubomir-popov Please verify that the colors in the demo are correct

@bartaz bartaz merged commit 0c48700 into canonical:main Jun 14, 2024
6 checks passed
@jmuzina jmuzina deleted the article-pagination-theming branch June 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants