Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ascending/descending icons on sortable tables #5135

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Jun 13, 2024

Done

  • Swap the icons on ascending/descending column headers so they point the correct directions

Fixes WD-12133

QA

  • Open sortable table demo
  • Sort the table by a given column header
  • Witness that the ascending/descending icons point the correct directions

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Screenshot from 2024-06-13 11-57-32

@webteam-app
Copy link

@pastelcyborg pastelcyborg added Review: QA needed Review: Code needed Bug 🐛 Review: Percy needed This PR needs a review of Percy for visual regressions labels Jun 13, 2024
@pastelcyborg pastelcyborg marked this pull request as ready for review June 13, 2024 11:06
@bartaz
Copy link
Contributor

bartaz commented Jun 13, 2024

@dgtlntv @danielmutis Just FYI - it seems that the sorting direction arrow in our tables have been wrong. So we are reversing those.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@pastelcyborg pastelcyborg merged commit 8d1ea39 into canonical:main Jun 13, 2024
6 checks passed
@pastelcyborg pastelcyborg deleted the correct-sortable-table-sort-indicators branch June 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants