Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy examples combination - base/lists #5147

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 17, 2024

Combines base/lists examples.

Depends on #5142 (includes its code)

QA

@webteam-app
Copy link

@jmuzina jmuzina changed the base branch from main to percy-examples-combination June 17, 2024 20:38
@jmuzina jmuzina force-pushed the examples-combination-base-lists branch from 6870838 to 3edffce Compare June 17, 2024 20:41
@jmuzina jmuzina marked this pull request as ready for review June 17, 2024 21:05
@jmuzina jmuzina force-pushed the percy-examples-combination branch from f14436c to d1a0dbc Compare June 18, 2024 15:24
@jmuzina jmuzina force-pushed the examples-combination-base-lists branch from ee2f12f to 319ac1a Compare June 24, 2024 14:37
@jmuzina jmuzina merged commit 7099ae2 into canonical:percy-examples-combination Jun 24, 2024
4 checks passed
@jmuzina jmuzina deleted the examples-combination-base-lists branch June 24, 2024 14:37
jmuzina added a commit to jmuzina/vanilla-framework that referenced this pull request Jun 26, 2024
* base/lists

* spacing option in example template

* rm combined.scss (superseded by rem spacing)
jmuzina added a commit that referenced this pull request Jun 26, 2024
* base/lists

* spacing option in example template

* rm combined.scss (superseded by rem spacing)
jmuzina added a commit that referenced this pull request Jun 27, 2024
* base/lists

* spacing option in example template

* rm combined.scss (superseded by rem spacing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants