Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy examples combination - base/paper #5148

Open
wants to merge 3 commits into
base: percy-examples-combination
Choose a base branch
from

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 17, 2024

Combines base/paper examples.

Depends on #5142 (includes its code)

QA

This example should be revisited later - it is very theme-specific and I'm not yet sure what .on-paper is for (is it to be deprecated once all sites move to paper background?) - in this implementation this combined example will be screenshotted on light & dark for no reason, but I think it's worth it since we are decreasing our usage so much in other areas.

@jmuzina jmuzina self-assigned this Jun 17, 2024
@webteam-app
Copy link

@jmuzina jmuzina force-pushed the examples-combination-base-paper branch from 408b3dc to 9cddc78 Compare June 17, 2024 21:21
@jmuzina jmuzina marked this pull request as ready for review June 17, 2024 21:26
@jmuzina jmuzina force-pushed the percy-examples-combination branch from f14436c to d1a0dbc Compare June 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants