Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy examples combination - patterns/ simple combinations #5152

Open
wants to merge 22 commits into
base: percy-examples-combination
Choose a base branch
from

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 18, 2024

Combines simpler examples from patterns/ directory. Simple examples are examples for which we are not deleting or moving any example files; we are simply adding a combined.html file that includes all of the other examples for that component. This was done to prevent having to separately review many PRs with identical QA tasks.

This PR adds combinations for:

  • accordion
  • badge
  • card
  • empty state
  • equal height row
  • grid
  • heading icons
  • headings
  • hero
  • image
  • media object
  • pagination
  • pull quote
  • section
  • segmented control
  • strip
  • tab button
  • table of contents
  • tooltips

As a drive-by, I also altered the all aspect ratios image container example to embed the 16-9 example instead of duplicating its code.

Depends on #5142 (includes its code)

QA

@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review June 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants