Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy examples combination - patterns/buttons #5153

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 18, 2024

Combines button examples

Depends on #5142 (includes its code)

Deletes the dark button example & its embedding in the button docs

QA

@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review June 18, 2024 17:39
@jmuzina jmuzina force-pushed the examples-combination-patterns-buttons branch from 7820025 to 172e304 Compare June 18, 2024 20:09
@jmuzina jmuzina self-assigned this Jun 19, 2024
@jmuzina jmuzina force-pushed the examples-combination-patterns-buttons branch from d756cd0 to f99dd33 Compare June 24, 2024 14:54
@jmuzina jmuzina merged commit d077bd4 into canonical:percy-examples-combination Jun 24, 2024
3 of 4 checks passed
@jmuzina jmuzina deleted the examples-combination-patterns-buttons branch June 24, 2024 14:54
jmuzina added a commit to jmuzina/vanilla-framework that referenced this pull request Jun 26, 2024
* patterns/buttons

* spacing option in example template

* rm combined.scss (superseded by rem spacing)
jmuzina added a commit that referenced this pull request Jun 26, 2024
* patterns/buttons

* spacing option in example template

* rm combined.scss (superseded by rem spacing)
jmuzina added a commit that referenced this pull request Jun 27, 2024
* patterns/buttons

* spacing option in example template

* rm combined.scss (superseded by rem spacing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants