Percy examples combination - patterns/contextual-menu
#5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
jmuzina
changed the title
patterns/contextual-menu
jmuzina
force-pushed
the
examples-combination-patterns-contextual-menu
branch
from
8447392
to
4f7c58d
Compare
jmuzina
force-pushed
the
examples-combination-patterns-contextual-menu
branch
from
dd99813
to
7e1fac6
Compare
jmuzina
force-pushed
the
examples-combination-patterns-contextual-menu
branch
from
69fa0c3
to
7eb7e1a
Compare
pastelcyborg
approved these changes
Jun 20, 2024
jmuzina
force-pushed
the
examples-combination-patterns-contextual-menu
branch
from
e0c5d77
to
7682c1b
Compare
bartaz
merged commit 4950e68
into
canonical:percy-examples-combination
3 of 4 checks passed
jmuzina
added a commit
to jmuzina/vanilla-framework
that referenced
this pull request
Jun 26, 2024
* patterns/contextual-menu * spacing option in example template * apply rem spacing to context menu * rm combined.scss (superseded by rem spacing)
jmuzina
added a commit
that referenced
this pull request
Jun 26, 2024
* patterns/contextual-menu * spacing option in example template * apply rem spacing to context menu * rm combined.scss (superseded by rem spacing)
jmuzina
added a commit
that referenced
this pull request
Jun 27, 2024
* patterns/contextual-menu * spacing option in example template * apply rem spacing to context menu * rm combined.scss (superseded by rem spacing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines contextual menu
Depends on #5176 (includes its code)
Deletes the dark example and removes it from docs.
Special case where there is risk of combined examples overlapping each other; uses code from #5176 to ensure no overlap.
This can be merged after merging of #5176 .
QA