Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes logos in darkmode #255

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Fixes logos in darkmode #255

merged 3 commits into from
Nov 30, 2022

Conversation

madsrh
Copy link
Contributor

@madsrh madsrh commented Nov 30, 2022

Releated to #70
Added a mediaquery for darkmode to the SVG files. Sadly I wasn't able to test this 🙈 🤞

I couldn't find any guidelines for the Devuan logo, so I'm not sure if it looks better in black or perhaps with a subtle stroke.

Added a mediaquery for darkmode to the SVG files
@jpnurmi
Copy link
Contributor

jpnurmi commented Nov 30, 2022

Awesome, thanks! 🤩 Unfortunately, the flutter_svg library doesn't support <style> elements but we could have separate files with dark variants. I'll take a look!

════════ Exception caught by SVG ═══════════════════════════════════════════════
The following UnimplementedError was thrown in parseSvgElement:
The <style> element is not implemented in this library.

Style elements are not supported by this library and the requested SVG may not render as intended.

flutter_svg doesn't support <style> element :(
Either `<os>-light.svg` or `<os>-dark.svg` is looked up first depending
on the theme brightness and if not found, falls back to `os.svg`.
@jpnurmi
Copy link
Contributor

jpnurmi commented Nov 30, 2022

Thank you, @madsrh! This is a huge improvement :)

os-logos.webm

@jpnurmi jpnurmi merged commit 176c34e into canonical:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants