Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restart intro support #22

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Add restart intro support #22

merged 3 commits into from
Jan 3, 2024

Conversation

cp-megh-l
Copy link
Collaborator

@cp-megh-l cp-megh-l commented Jan 3, 2024 •
edited

Changelog

  • Introduce a restart handler in IntroShowcaseManager for restarting the IntroShowcase
  • When the restart handler is invoked, it resets the current target index to 0, providing a way to restart the IntroShowcase
  • Update function name in index.md according to latest implementation
  • Rename ShowcaseState file according to class name i.e., IntroShowcaseState
restart.intro.mp4

cp-radhika-s
cp-radhika-s reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@cp-radhika-s cp-radhika-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add reset in IntroShowcaseState instead of IntroShowcaseManager

@cp-megh-l cp-megh-l merged commit 1245bde into master Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-radhika-s cp-radhika-s cp-radhika-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cp-megh-l @cp-radhika-s