Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Swipe/Drag Directions #9

Merged
merged 3 commits into from
Jan 17, 2024
Merged

BugFix: Swipe/Drag Directions #9

merged 3 commits into from
Jan 17, 2024

Conversation

cp-megh-l
Copy link
Collaborator

@cp-megh-l cp-megh-l commented Jan 17, 2024 •
edited

Changelog

  • Added support for specifying swipe direction and drag direction in ItemTouchHelperConfig.

Bugfix

  • Resolved an issue where the onSwipe lambda was ineffective due to the default swipeDirs being set to 0 in the ItemTouchHelper constructor(issue)

cp-radhika-s
cp-radhika-s requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@cp-radhika-s cp-radhika-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ignore and remove .idea/ * .

Otherwise, looks fine to me.

@cp-megh-l cp-megh-l merged commit 258f4e3 into master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-radhika-s cp-radhika-s cp-radhika-s requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cp-megh-l @cp-radhika-s