Fix settle up calculation

[cp-amisha-i]

Reverts #39

Summary by CodeRabbit

• New Features
  • Enhanced debt settlement logic to simplify user experience.
• Improvements
  • Improved error handling in various view models.
  • Simplified and refined expense calculation methods across multiple components.
  • Updated display and formatting for several views to enhance readability and user interaction.
• Bug Fixes
  • Fixed issues related to text alignment and trimming in user input fields.
• Localization
  • Removed outdated localization strings for improved accuracy and relevancy.
• Documentation
  • Updated dependency injection and method documentation for better clarity.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The recent updates streamlined various components in the Splito project by removing redundant parameters, refining logic for user input handling, enhancing expense and group data calculations, and improving view component structures. Significant changes include removing isPaymentSettled from AppRoute and related files, removing leading/trailing spaces trim, updating localization, enhancing dependency injection, and simplifying debt settlement logic across different view models.

Changes

File(s)	Change Summary
AppRoute.swift, GroupSettleUpRouteView.swift	Removed isPaymentSettled parameter from GroupWhoIsPayingView in AppRoute enum and its usage in switch statement
Splito.xcodeproj/project.pbxproj	Removed CalculateExpensesFunctions.swift from build files and file references
Localizable.xcstrings	Removed localization key "You are settled up overall."
UserProfileViewModel.swift	Removed trimming of spaces for user profile information updates, retained capitalization only
AddExpenseViewModel.swift, CreateGroupViewModel.swift	Updated logic for handling expense and group names to capitalize without trimming spaces
GroupBalancesView.swift, GroupTotalsView.swift	Added import Data statement
GroupBalancesViewModel.swift, GroupTotalsViewModel.swift	Adjusted dependency injections, simplified logic for expense calculations and balance processing
GroupSettleUpViewModel.swift, GroupTransactionListViewModel.swift, GroupSettingViewModel.swift, GroupListViewModel.swift	Enhanced dependency injection, adjusted property initializations and method logic for expense and transaction handling
GroupPaymentView.swift	Reordered ScrollView and VStack elements, adjusted view logic and styling
GroupWhoIsPayingView.swift, GroupWhoIsPayingViewModel.swift	Removed isPaymentSettled-related logic, adjusted onAppear block for fetching group members
GroupTransactionDetailView.swift	Removed multilineTextAlignment(.center) from text alignment logic
GroupExpenseListView.swift, GroupHomeView.swift, GroupHomeViewModel.swift	Refined conditional display logic, structured parameters and member owing amounts calculation

Poem

Amid the code, a bunny springs,
Tweaking views with merry flings.
Parameters trimmed, logic refined,
Splito's heart and soul aligned.
With every change, expenses neat,
Groups and members now complete. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.