internal/tmpl: fix static/dynamic invariants #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floodfx
reviewed
Apr 15, 2023
floodfx
reviewed
Apr 15, 2023
to make vscode stop chattering at me
This reduces noise when running all tests.
josharian
force-pushed
the
josh/tmpl-experiments
branch
from
735903b
to
5b430af
Compare
|
This is a lot of changes. But note that the core functionality change is actually net negative LOC. |
This makes the code better organized, better documented, and generally clearer. Hopefully also more correct. Importantly, it makes WriteTo not mutate the Tree.
It is in its own package because there's no natural home for it, and putting it directly in internal/tmpl causes cyclical imports.
josharian
force-pushed
the
josh/tmpl-experiments
branch
from
5b430af
to
d82f51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to preserve the invariants more carefully during tree construction. And fixed some assorted things that looked wrong while I poked around the code.
So far (about 10M runs), this passes the fuzz test I added in #19. I'll let it run for a while longer.
I had to "fix" a few golden tests, so maybe I busted something, though. I don't really understand the format when it comes to ranges. I'd be curious to see how it works in practice.