Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live: rate limit error responses #31

Merged
merged 1 commit into from
May 10, 2023
Merged

live: rate limit error responses #31

merged 1 commit into from
May 10, 2023

Conversation

josharian
Copy link
Contributor

No description provided.

@josharian josharian requested review from floodfx and kevboh May 10, 2023 18:26
@josharian
Copy link
Contributor Author

For discussion: do we even want this? If so, do we want to expose the 15 seconds and burst as config parameters?

@floodfx
Copy link
Contributor

floodfx commented May 10, 2023

For discussion: do we even want this? If so, do we want to expose the 15 seconds and burst as config parameters?

I like it. Doesn't hurt to be too careful. Exposing seems reasonable if nothing more to make it visible to folks.

@josharian
Copy link
Contributor Author

josharian commented May 10, 2023 •
edited
Loading

Cool. Let's leave hard-coded for the moment--it is easier to add API than to delete it.

@josharian josharian merged commit d0273c0 into main May 10, 2023
@josharian josharian deleted the josh/rate-limit-errors branch May 10, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floodfx floodfx floodfx approved these changes

@kevboh kevboh Awaiting requested review from kevboh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josharian @floodfx