Make framebuffer_update public #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to get device for updating ioctl based fixed_screen_info (yeah, that changes in some cases). Example: https://github.com/LinusCDE/plato/blob/4208d76a/src/framebuffer/remarkable.rs#L288
|
Yeah... it would be nice to have better abstractions here, and maybe we'll get to it someday, but this seems like the right call in the meantime. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this variable to be public, since you can't rotate the framebuffer in hardware otherwise (rm 1 only). Thought I could get away with a new instance, but since the new instance re initializes my changed data (and resets the rotation value), it wouldn't work that way.
On the rM 2, I know do this in software (was disabled there until now) but for the rM 1 I prefer to let the hardware do the pixel transformation.
Another solution to this would be to implement this as part of a new function to update the fix_screen_info. But I recon nobody except me will ever need this, and it might sound weird to "update fixed info". But I have no problems doing this instead if preferred.