Fix: Built-in rm2fb client corrupts the server state #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was an analog to the destroy() call on the c++ side. Assumed this would be used by the client when closing, but turns out, not the client neither the server ever call this code. Seem to be an unused function that tripped my when implementing it. Dropping a framebuffer would cause the rm2fb stuff not to work for any app until next reboot (effectively freezing the display).
|
I have confirmed this pull request fixes #88 |
Nice!
Slight variations usually work on GitLab. And GitHub even confirms this should work:
|
Noticed that, which is why I deleted that part from my comment |
|
Will take your confirmation as review and go ahead to merge this. (The CI failures seem to be GitHubs fault, not one of the actual changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting problems found so far. Should in the end fix the issue found in #88. This will close #88.