ui patch agent show #1326
Merged
ui patch agent show #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
|
|
||
| <%= javascript_tag do %> |
There was a problem hiding this comment.
New code should go in agent-show-page.js.coffee. Can bind it at the top. Also see the jQuery toggle method.
| `$( "#target" ).click(function() { | ||
| $("#memorytoggle").toggleClass("hidden"); | ||
| });` | ||
|
|
There was a problem hiding this comment.
The code does not work here even though I tried both passing in a pure js and converted it to coffee. However it works in show.html.erb.
|
@cantino This is good too. Its working for me. |
| @@ -1,5 +1,8 @@ | |||
| class @AgentShowPage | |||
| constructor: -> | |||
| $('#target').click -> | |||
| $('#memorytoggle').toggleClass 'hidden' | |||
| return | |||
There was a problem hiding this comment.
return isn't needed here, it'll return automatically
|
@cantino I am good with another look. |
| @@ -40,6 +41,12 @@ class @AgentShowPage | |||
| $("#logs .spinner").stop(true, true).fadeOut -> | |||
| $("#logs .refresh, #logs .clear").show() | |||
|
|
|||
| toggleMemory: -> | |||
| if $('#memorypanel').hasClass('hidden') | |||
| $('#memorypanel').removeClass 'hidden' | |||
There was a problem hiding this comment.
It looks like the button text does not change anymore when you show the memory, is that intended?
|
@cantino I think I am good. I double checked. |
|
Thanks @Jngai! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.