-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui patch agent show #1326
Merged
Merged
ui patch agent show #1326
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7fd6ff3
ui patch agent show
6f46da0
switched to toggle jquery method
fdbb055
attempt to convert js to coffee
e2f2f47
attempt to convert js to coffee
e6b96b1
added in another code option
caa4c3e
done got it to work
c96e402
rm code from view and indent properly
6e26e9f
js code show page
7a9b405
made button text dependent updated jquery
e86045c
defining js code a bit down
f3209c0
rewrote code into an instance property and added it to the constructor
61b8e0a
rm unnecessary e params into method
b7f906e
fixed spacing
60db396
last fix to spacing
6b212c8
fixing html related errors
508fe28
made button text dynamic with jquery text
b226a78
unnecessary change
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,17 +161,31 @@ | |
<b>Options:</b> | ||
<pre><%= Utils.pretty_jsonify @agent.options || {} %></pre> | ||
</p> | ||
|
||
<p id="memory" data-agent-id="<%= @agent.id %>"> | ||
<b>Memory:</b> | ||
<% if @agent.memory.present? %> | ||
<i class="fa fa-spinner fa-pulse spinner"></i> | ||
<i class="fa fa-trash action-icon clear"></i> | ||
<% end %> | ||
<pre class="memory"><%= Utils.pretty_jsonify @agent.memory || {} %></pre> | ||
</p> | ||
<button type="submit" class="btn btn-default" id="target">Reveal Memory</button> | ||
<button type="submit" class="btn btn-default" id="target1">Hide Memory</button> | ||
<div id="memorytoggle" class="hidden"> | ||
<p id="memory" data-agent-id="<%= @agent.id %>"> | ||
<b>Memory:</b> | ||
<% if @agent.memory.present? %> | ||
<i class="fa fa-spinner fa-pulse spinner"></i> | ||
<i class="fa fa-trash action-icon clear"></i> | ||
<% end %> | ||
<pre class="memory"><%= Utils.pretty_jsonify @agent.memory || {} %></pre> | ||
</p> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
|
||
<%= javascript_tag do %> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New code should go in agent-show-page.js.coffee. Can bind it at the top. Also see the jQuery toggle method. |
||
$( "#target" ).click(function() { | ||
$("#memorytoggle").removeClass("hidden"); | ||
}); | ||
|
||
$( "#target1" ).click(function() { | ||
$("#memorytoggle").addClass("hidden"); | ||
}); | ||
<% end %> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added one opening
div
and two closing/div
s, I think one of the closing divs needs to be removed.