Show recently received events in dry run modal #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice stuff, looks useful! |
dsander
force-pushed
the
feature/dry-run-events
branch
from
11f63c0
to
573f27f
Compare
| @@ -26,6 +24,14 @@ | |||
| end | |||
|
|
|||
| resources :events, :only => [:index] | |||
|
|
|||
| scope module: :agents do | |||
There was a problem hiding this comment.
Is this the same as a namespace?
There was a problem hiding this comment.
Almost, as far as I know the only difference are the route names.
For namespace: agent_agents_dry_runs and agents_dry_runs.
For scope: agent_dry_runs and dry_runs.
|
Nice idea! |
| @@ -20,6 +20,25 @@ def valid_attributes(options = {}) | |||
| expect(assigns(:events)).to eq([]) | |||
| end | |||
|
|
|||
| context "does not load events when the agent is owned by a diffrent user" do | |||
|
Looks good! |
dsander
force-pushed
the
feature/dry-run-events
branch
from
6ab97a6
to
d573b98
Compare
|
Thanks for the review! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes testing and modifying Agents easier by providing a list of received events to choose from in the dry run modal.
Thanks to kreuzwerker.de who are paying me to work on this in the context of the research project 'Digitale Kuratierungstechnologien' of which they are a part of.