PushoverAgent: Treat parameter options as templates rather than default values #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt values This should fix #1718. While at it, character limit implementation is fixed: `slice(0..n)` would take the first n+1 characters instead of n.
dsander
reviewed
Oct 4, 2016
| end | ||
|
|
||
| def suffix_for(key) | ||
| "{% endcapture %}" << DEFAULT_OPTIONS[key].sub(/(?=\}\}\z)/, '| default: _default_ ') |
There was a problem hiding this comment.
Shuldn't that be '| default: _default_ }}'?
There was a problem hiding this comment.
Actually (?=\}\}\z) is a zero-width pattern so I don't need to overwrite the }} in the match. 😁
There was a problem hiding this comment.
Interesting, one can learn something new about regex every day 😛
cantino
approved these changes
Oct 4, 2016
| * `token`: your application's API token | ||
| * `user`: the user or group key (not e-mail address). | ||
| * `expected_receive_period_in_days`: is maximum number of days that you would expect to pass between events being received by this agent. | ||
|
|
||
| Your event can provide any of the following optional parameters or you can provide defaults: | ||
| The following options are all Liquid templates which evaluated values will be posted to Pushover API. Only the `message` parameter is required, and if it is blank API call is omitted. |
There was a problem hiding this comment.
"The following options are all Liquid templates whose evaluated values will be posted to the Pushover API."
|
Very interesting! |
dgw
approved these changes
Oct 4, 2016
|
Thanks for the review and testing, I'm merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1718.
While at it, character limit implementation is fixed:
slice(0..n)would take the first n+1 characters instead of n.