Update README with Windows/pwsh instructions, and use data_local_dir to use %LOCALAPPDATA% on Windows #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jtschuster. Do we need to check data_dir in case the user already has a mcfly data dir there? |
|
Is this ready to go? |
Yes, it is! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instructions for installing for Windows, and configuring for powershell.
Use
data_local_dirinstead ofdata_dirto useC:\Users\username\AppData\Localinstead ofC:\Users\username\AppData\Roamingto avoid syncing large DBs across machines. The path remains the same on Linux and Mac.Also, updates references to OS X to macOS.