Crash opening "Conflict Resolver" #224
Comments
|
Thanks: I'll look into this |
|
Mind testing https://ci.appveyor.com/project/canton7/synctrayzor/build/1.1.5.295/artifacts, see if that fixes the issue? Thanks! |
|
thanks for the efforts, but this does not even start. |
|
Can you confirm whether |
|
... it should be, but it looks like yours may have gone missing (maybe an antivirus program?) |
|
I checked the md5 hash of x64 and x32 zip files. Both donwloads are |
|
I can assure you that both do. Try inspecting the contents of the zip without exacting it: you'll see this:
Additionally, if that file didn't exist in the zip, I'd have several hundred portable users after my blood because I'd broken the portable build. I think you've got some hyper-paranoid antivirus or anti-malware which is quarantining files that it shouldn't. That would also explain the crash you saw trying to open the conflict resolver: something was blocking me from getting the icon associated with a particular file type, which I've never seen before. |
|
Clean bill of health on VirusTotal |
|
It's just generated COM interop types - nothing which could be remotely malicious. Still, something seems very keen to get rid of them whenever they crop up on @Kugeleis's machine... |
|
I reloaded the x64 zip and now it runs but with the same dead on opening the conflict resolver. |
|
Something on your computer really doesn't like working with images... Try this build: https://ci.appveyor.com/project/canton7/synctrayzor/build/1.1.5.297/artifacts |
|
Tried again and actually on two other machines (Win7 pro 64bit) with the same effect crashing as soon as I open the conflict solver. So I guess it's not the machine but rather the set of files or localization. |
|
The bit that's having problems is the code which finds the icon advocated associated with a particular file type, so maybe you've got some file type that's got a really odd associated icon, or is in a weird format, etc? The first error was it not being able to find an icon (I think), the second was windows being unable to find a codec for the icon. Have you tried that build I linked to above? That should work around that second error. On 31 January 2016 16:37:59 GMT+00:00, Kugeleis notifications@github.com wrote:
|
|
I sync flac files. They might contain strange icons. But flac is not an |
|
I think it's specifically the icon which is associated with the file type on those computers. Have you tried that build I linked to above yet? |
|
Could you let me know whether this build works, please? https://ci.appveyor.com/project/canton7/synctrayzor/build/1.1.5.297/artifacts I'd like to push out a new release soon, but I want to know whether or not to include that workaround. |
|
This also gets stuck when entering the solver. |
|
Log? It won't be the same error. |
|
Thanks! |
|
SyncTrayzor logs some information on startup: mind pasting it? |
|
Sorry, I deleted the begin. Need to redo the test. |
|
Much appreciated! |
|
... it's just the line numbers in the stack trace only make sense if you weren't running v1.1.5.297, so I want to see which version it thinks it is on startup. |
|
Just to make sure: you're not downloading the v1.1.5.297 zip, copying SyncTrayzor.exe out of it and pasting it into a previously downloaded zip or something, are you? |
|
No, I use the full pack and copy the syncthing config in. Am 1. Februar 2016 23:16:43 MEZ, schrieb Antony Male notifications@github.com:
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet. |
|
here are the first lines of the log 2016-02-01 23:39:07.4969 #1824 [Info] SyncTrayzor.Services.SingleApplicationInstanceManager: Checking for other SyncTrayzor processes |
|
Thanks. Weird. I'll check tomorrow that the right version of one of the dlls got out in that zip. |
|
Argh, sorry, that was my screw-up. This release has the fix I intended you to get: https://ci.appveyor.com/project/canton7/synctrayzor/build/1.1.5.299/artifacts . What program is associated with your flac files, i.e. what program opens if you double-click a flac file? It would be great if I could reproduce your problem on my end, since this back-and-forth debugging is slow and painful for everyone. |
|
.flac is associated with the vlc-player. |
|
Hrm, VLC's icon is fine - I've used that... |
|
OK, I tested 1.1.5.299 an 1.1.6 and they stll get stuck. |
|
Log please? |
|
OK, I isolated the issue a bit. When reducing syncthing to one folder the solver works. Even with flac files. Apparently it crashes when my syncthing handles multiple folders. |
|
It was previously crashing when trying to render the icon for a particular file (I'm not sure what the issue is now, since we should have caught all of the places where that crash could have occurred). |
|
I'll go through each folder now and let you know if one causes the crash. |
|
I'm afraid I can't do anything until I see why the crash is happening now, and for that I need the log. |
|
It probably doesn't seem this way from where you're standing, but so far we've fixed one crash caused by apparently funky icons, and probably fixed another. This is indicated by the stack trace in the logs: that tells me which function call failed, and if I'm lucky tells me why. I'm not sure what your current crash is caused by: I need to see the logs to see what's failing, and why. |
|
After running folder by folder I had no crash anymore. All folders worked well when handled one by one. I just checked the log. It's huge and has private data all over. I wonder if I can filter something useful still for debugging. |
|
The section just before the crash occurred, as you've been doing so far, is fine. Specifically, any line starting with "An unhandled AppDomain exception occurred" or "An unhandled exception occurred" and all of the lines below it which don't start with a timestamp (e.g. all of the ones starting with "bei"). Also feel free to email me anything directly if you don't want to post it on here: my email is on my github profile page. |
|
You got mail. |
|
OK, thanks for that log. There's some very scary stuff in there - failures from some core parts of .NET, stuff like that. It makes me think that a bad icon isn't the source of the problem: there's something much more fundamental. You're not doing anything like running over remote desktop, in a virtual machine, etc, are you? Could you open Task Manager, go to the 'Details' tab, right-click on one of the column headers, click 'Select Columns', then check 'GDI objects'. Open the conflict resolver window, and see if this value increases (and what value it increases to). Do the same for the 'User objects' column. There's also something else I can try if that doesn't yield anything interesting... |
|
Em, sorry, I'm on a Win7 prof machine now. I guess the task manager is more basic. |
|
Does it go up at all if you open the conflict resolver window? |
|
Yes, actually dramatically to >4500. When I gradually reduce the conflicting files the handles reduce, too. Since my data has thousends of those "sync-conflict" files due to some buggy early syncthing version your code might run into some unexpected limit. I wrote a ps script earlier to get rid of them but never dared to run it on real data ;~) |
|
Oops wrong button... |
|
Amazing, thank you! You've probably guessed it, but it looks like I'm leaking GDI handles through those file icons. I should also be able to reproduce this now, so I should be able to get it fixed without annoying you any more. |
|
I'm done now anyway. Thanks for your patience. I'll pay in translations :-] |
|
Thanks for your patience and help as well! Debugging a problem like this, where I can't reproduce it and I'm relying on you for feedback, is an incredibly lengthy and irritating process for both parties, and I really appreciate your perseverance 😄 |
|
Righty, this should be fixed: https://ci.appveyor.com/project/canton7/synctrayzor/build/1.1.6.305/artifacts |
|
Release in v1.1.7. |
Running 1.1.5 64bit on windows 10; when opening the conflict resolver the program stops responding;
https://ci.appveyor.com/project/canton7/synctrayzor/build/1.1.1.236/artifacts crashes, too.
here is the last part of the log
SyncTrayzor.txt
The text was updated successfully, but these errors were encountered: