Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unused imports #529

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Check for unused imports #529

merged 2 commits into from
Mar 2, 2023

Conversation

zariiii9003
Copy link
Collaborator

I activated the isort (I) and unused-imports (F401) checks.

@zariiii9003 zariiii9003 requested a review from andlaus March 1, 2023 23:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4309068404

  • 125 of 126 (99.21%) changed or added relevant lines in 33 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 94.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cantools/typechecking.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
cantools/typechecking.py 1 89.29%
Totals Coverage Status
Change from base Build 4305865330: -0.03%
Covered Lines: 7033
Relevant Lines: 7476

💛 - Coveralls

Copy link
Member

@andlaus andlaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. the only issue which might crop up with this is that it becomes harder to reproduce CI failures locally, in particular for "drive-by" contributors. (Let's see if this becomes a problem...)

@zariiii9003
Copy link
Collaborator Author

zariiii9003 commented Mar 2, 2023

That shouldn't be a problem, if we update the contribution instructions in the readme https://github.com/cantools/cantools/blob/master/README.rst#contributing

You can run the checks locally with ruff check .\cantools\

@zariiii9003 zariiii9003 merged commit 1444ccd into cantools:master Mar 2, 2023
@zariiii9003 zariiii9003 deleted the ruff2 branch March 2, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants