Activate pyflakes check #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4359318064
💛 - Coveralls |
andlaus
reviewed
Mar 2, 2023
| @@ -1796,16 +1794,16 @@ def _load_linear_scale(self, compu_scale, decimal): | |||
| if lower_limit is not None and \ | |||
| upper_limit is not None and \ | |||
| lower_limit > upper_limit: | |||
| LOGGER.warning(f'An valid interval should be provided for ' | |||
There was a problem hiding this comment.
can we disable F541? I'd like to be able to use F-strings even in situations where nothing is formatted...
There was a problem hiding this comment.
That's weird but it should be possible. Are you sure? 😄
There was a problem hiding this comment.
Are you sure?
quite: IMO, having to use two different kinds of strings for things like
print(f"there is a problem ({id=}) with whatever stupid thing I wanted to do "
f"and this needs to be fixed before we can proceed because if not, "
f"world #{world_id} is gonna end")looks pretty weird...
(also, I like to use f-strings for stuff which could potentially include formatting even if they do not at the moment.)
I'm not hell-bent on that matter, though, so if you really want F541, let's keep it active...
There was a problem hiding this comment.
I don't have a strong opinion about that one. I'll make the change and force push.
|
going in. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.