Misc fixes #541
Merged
Misc fixes #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is for the benefit of people who use the VSCode IDE... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
This skips printing anything that relies on format-specific information. The main purpose of this is to be able to check if two files using different formats represent the same database. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
If applicable, we now print the unit for the pre-defined signal values (because these are physical values) and we also alow to specify the format specifier for physical signal values in the list parser. The latter change allows to get around rounding errors when comparing databases stemming from conversion of one file format to another. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
this is IMO less confusing as `signal.type` only specifies the type which is used to internally represent the signal. In the physical world, all signals are either floating point values or enumerations. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
the first signal is the current speed of the vehicle to be displayed by the instrument cluster, the second is the target speed for the cruise control ECU. So far, both were called "SpeedKm"... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
The system signal is supposed to be transported by a given interaction signal, i.e. to get a "global" state of the system, one must use the system signals which can be transported by multiple interaction signals of multiple PDUs... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
…time of multiplexed messages cantools' data model currently does not support specifying cycle times for a subset of a message signals different from the cycle time of the message but ARXML does. (Personally, I much prefer the simplicity of cantools, but we need to somehow handle this case...) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
such PDUs do not exist in AR4, but AR3 specifies non-signal bearing PDUs this way... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
Pull Request Test Coverage Report for Build 4595714280
💛 - Coveralls |
|
@zariiii9003 or @juleq: can you have a look at this? For this PR I recommend looking at the patches individually as they are all pretty small and should be self-contained. (in principle, each of them could be done as a separate PR...) |
|
Yes, i wanted to get #536 merged first, i'll get that done today, i think. |
zariiii9003
reviewed
Apr 3, 2023
zariiii9003
reviewed
Apr 3, 2023
zariiii9003
reviewed
Apr 3, 2023
zariiii9003
reviewed
Apr 3, 2023
zariiii9003
reviewed
Apr 3, 2023
thanks goes to [at]zariiii9003 Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
turns out that f-strings are sufficient after all. many thanks to [at]zariiii9003 for the hint! Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
zariiii9003
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of smaller fixes and improvements for stuff which I recently stumbled over and which are IMO not enough to open a pull request on their own. Probably the change with most potential for controversy is 298d2c8, which causes the
listtool to treatsignal.{initial,invalid,minimum,maximum}as physical values. (The ARXML loader has been doing this for quite some time by now, the other formats will hopefully be switched to using physical quantities for all user-facing values soon.)Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information