Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal: slightly refactor scaled_to_raw() and raw_to_scaled() #557

Merged
merged 1 commit into from
May 12, 2023

Conversation

andlaus
Copy link
Member

@andlaus andlaus commented May 11, 2023

mainly, we now refrain from doing fancy stuff with exceptions...

Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information

@andlaus andlaus requested a review from zariiii9003 May 11, 2023 12:29
@coveralls
Copy link

coveralls commented May 11, 2023

Pull Request Test Coverage Report for Build 4947997227

  • 8 of 17 (47.06%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.982%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cantools/database/can/signal.py 8 17 47.06%
Totals Coverage Status
Change from base Build 4908011923: -0.01%
Covered Lines: 7074
Relevant Lines: 7527

💛 - Coveralls

mainly, we now refrain from doing fancy stuff with exceptions...

Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: Gerrit Ecke <gerrit.ecke@mbition.io>
@andlaus andlaus force-pushed the refactor_signal_scaling_methods branch from b007a36 to 97eb3c0 Compare May 11, 2023 12:36
@andlaus andlaus merged commit 16bc511 into cantools:master May 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants