Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAN-FD detection for dbc files #567

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

1atabey1
Copy link
Contributor

Properly populates the is_fd flag for messages loaded from dbc files.

Also indirectly fixes the dbc file dump of previously loaded files that either contain FD frames or have values other than StandardCAN as a default in their frame format definition.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5023069999

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 93.858%

Totals Coverage Status
Change from base Build 4992757571: 0.006%
Covered Lines: 7228
Relevant Lines: 7701

💛 - Coveralls

Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@andlaus andlaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections from me either. @juleq?

@juleq
Copy link
Collaborator

juleq commented May 19, 2023

Yes, thanks. Merging.

@juleq juleq merged commit f5687d5 into cantools:master May 19, 2023
13 checks passed
@1atabey1 1atabey1 deleted the fd_detection_fix branch May 22, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants