Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to src repo structure #587

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

zariiii9003
Copy link
Collaborator

With this change, the tests will run on the packaged and installed code. Look at the paths in the coverage summary:

image

It looks like this on the master branch:
image

This should avoid bugs like in #584

@zariiii9003 zariiii9003 requested a review from andlaus June 27, 2023 08:21
@coveralls
Copy link

coveralls commented Jun 27, 2023

Pull Request Test Coverage Report for Build 5802707795

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 93.752%

Totals Coverage Status
Change from base Build 5801876635: -0.1%
Covered Lines: 21668
Relevant Lines: 23112

💛 - Coveralls

Copy link
Member

@andlaus andlaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle, this is okay IMO. That said, be aware that I'd like to significantly flatten the source tree soonish, so it might be worthwhile to do such changes in one go. (maybe not...)

tox.ini Show resolved Hide resolved
@zariiii9003
Copy link
Collaborator Author

in principle, this is okay IMO. That said, be aware that I'd like to significantly flatten the source tree soonish, so it might be worthwhile to do such changes in one go. (maybe not...)

I'd prefer not to change too much in a single PR.

@andlaus
Copy link
Member

andlaus commented Jun 27, 2023

I'd prefer not to change too much in a single PR.

alright. let's do it piecemeal then...

@zariiii9003 zariiii9003 marked this pull request as ready for review June 27, 2023 13:26
@andlaus
Copy link
Member

andlaus commented Aug 9, 2023

@zariiii9003: anything which needs to be changed here or can it be merged? (I would like to not keep this open for too long because this has quite a bit of headache potential.)

@zariiii9003 zariiii9003 merged commit 7389f06 into cantools:master Aug 10, 2023
16 checks passed
@zariiii9003
Copy link
Collaborator Author

@zariiii9003: anything which needs to be changed here or can it be merged? (I would like to not keep this open for too long because this has quite a bit of headache potential.)

Done 🙂

@zariiii9003 zariiii9003 deleted the src_repo branch August 10, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants