Refactor code for node mapped attributes. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5480055055
💛 - Coveralls |
andlaus
reviewed
Jun 30, 2023
There was a problem hiding this comment.
I like this in principle: the ARXML loader already takes the same approach via signal.autosar and database.autosar, etc. That said, I'm not really in a position to judge the merrits of DBC-specific stuff. Maybe @juleq can help out?
cantools/database/can/formats/dbc.py
Outdated
| for signal in message.signals: | ||
| if signal.dbc is not None and signal.dbc.attributes_rel is not None: | ||
| for node_name, node_dict in signal.dbc.attributes_rel.items(): | ||
| for _, attribute in node_dict.items(): |
There was a problem hiding this comment.
if you don't use the keys anyways, you can use this:
Suggested change
| for _, attribute in node_dict.items(): | |
| for attribute in node_dict.values(): |
…e database to message/signal dbc_specifics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the node mapped attributes are stored within the database dbc_specifics. This refactoring moves them to the more appropriate location within the message/signal dbc_specifics. It will be better when adding or removing message/signal, corresponding rel attributes will be easier to handle