WIP: isOwner = true if the user is a repo collaborator #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/grant_repo_collaborators_moderator_access
* upgrade to express 4 * upgrade to express 5 * client, server: remove headersJson files, set headers in express middleware --------- Co-authored-by: Bob Webb <bob.wbb@gmail.com>
This reverts commit a96efd9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
isOwnerfunction on the server to additionally check if the user is a repository collaborator on the proposals repository, i.e. that their entry in theusersdatabase hasis_repo_collaboratorset to true. This means that any endpoint that requires the user to be an owner (which includes administrators from the ADMIN_UIDS env var) can now also be called by repo collaborators.It also adds a line to the Account page that says whether the user is a repo collaborator:
Other changes:
c.hnamefilter from the manage conversations page - I don't know how this got in there a6b75acqueryPto be an object with arowsfield 4a62d6cisAdministratorcheck out of the loop that iterates over the conversations, this only needs to be done once f3cd31aTo do:
QA test all of the moderator behaviours