Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with SignOut component #22

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix bug with SignOut component #22

merged 1 commit into from
Dec 6, 2023

Conversation

rjwebb
Copy link
Contributor

@rjwebb rjwebb commented Dec 6, 2023

This was caused by this commit removing the connect function call from the SignOut class. 142e263#diff-bfd70249950b1dfc9882e91de16a924caf1a389a449da8acd6b7c43c826c47eaL1

In addition to passing in data from the reducers, connect also provides dispatch function, so when it was removed there was a runtime error... This PR updates the code to use useAppDispatch to get the dispatch function inside a functional component.

This PR has been QA tested - I logged in with a user, navigated to the Account page and clicked "Sign out", which successfully signed the user out.

Copy link
Member

@raykyri raykyri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raykyri raykyri merged commit 2e699d7 into main Dec 6, 2023
1 check failed
@rjwebb rjwebb deleted the rjwebb/fix-signout-bug branch December 14, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants