Add GitHub PR states to conversation list #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er it is a github fip pr
|
It was raised as a possibility that we could start syncing past/closed PRs too, so probably not a bad thing to have that in the sync job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the FIP conversation icon in the conversations list reflect the status of the corresponding PR. It does this by looking at the
github_pr_updated_at,github_pr_closed_atandgithub_pr_merged_atfields. It also adds a newgithub_pr_is_draftwhich says whether the PR is a draft.One change I had to make to the github sync code is that now we query for all PRs since we want to be able to know whether a PR is closed or merged. I think we can probably make this more efficient (e.g there is a n+1 query when getting the email address of users that have submitted PRs) but it seems to work.