-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.8 breaks require("canvg") #1484
Comments
@shanebdavis can you try canvg@3.0.9 ? |
3.0.9 still appears broken to me. 3.0.7 works perfectly (I use canvg as part of a process to download an SVG as an image) but 3.0.8 and 3.0.9 both only produce a blank white image. Honestly I'm not sure what issues it's related to and am happy to open a new issue certainly, but it appears to me likely related to 3.0.8 generally being a patch-release-regression and I'm not sure what, if anything, makes my setup unique. I use Canvg in the |
@Jason-Morcos Hi. Can you provide example of SVG? |
Hi @dangreen, thank you for the reply! Extracted SVG: |
@Jason-Morcos I can't reproduce this issue: on demo page all works fine Can you please provide minimal repo with reproduction? |
Closed due to inactivity. |
3.0.7 works with require("canvg")
I understand there is a desire to move towards ES modules, but 3.0.8 was a patch update; it shouldn't cause breaking changes. If such a breaking change is needed to further ES-module support, that should be a major version change e.g. 4.0.0.
I'd like to request a 3.0.9 release that restores CommonJS compatibility and a 4.0.0 release with the new ES-module changes.
The text was updated successfully, but these errors were encountered: